telemetry(inline-suggestion): Fix incorrect clientComponentLatency@preprocessLatency #6320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leigaol
approved these changes
Jan 8, 2025
jpinkney-aws
approved these changes
Jan 9, 2025
justinmk3
reviewed
Jan 13, 2025
| }) | ||
|
|
||
| it('setInvocationSuggestionStartTime should call resetClientComponentLatencyTime', function () { | ||
| const resetStub = sinon.stub(sut, 'resetClientComponentLatencyTime') |
Contributor
There was a problem hiding this comment.
sinon can be avoided for this entire test module. Can you change TelemetryHelper to return state that can be tested instead?
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
…eprocessLatency (aws#6320) ## Problem t1: user trigger inline suggestion either automatically or manually t2: start building request with editor context t3: done building request t4: call service API PreprocessLatency is supposed to denote `t3 - t1`, whereas current implementation isn't which has been using `codewhispererPreprocessingLatency: session.fetchCredentialStartTime - session.invokeSuggestionStartTime,` ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
…eprocessLatency (aws#6320) ## Problem t1: user trigger inline suggestion either automatically or manually t2: start building request with editor context t3: done building request t4: call service API PreprocessLatency is supposed to denote `t3 - t1`, whereas current implementation isn't which has been using `codewhispererPreprocessingLatency: session.fetchCredentialStartTime - session.invokeSuggestionStartTime,` ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
…eprocessLatency (aws#6320) ## Problem t1: user trigger inline suggestion either automatically or manually t2: start building request with editor context t3: done building request t4: call service API PreprocessLatency is supposed to denote `t3 - t1`, whereas current implementation isn't which has been using `codewhispererPreprocessingLatency: session.fetchCredentialStartTime - session.invokeSuggestionStartTime,` ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
t1: user trigger inline suggestion either automatically or manually
t2: start building request with editor context
t3: done building request
t4: call service API
PreprocessLatency is supposed to denote
t3 - t1, whereas current implementation isn't which has been usingcodewhispererPreprocessingLatency: session.fetchCredentialStartTime - session.invokeSuggestionStartTime,Solution
feature/xbranches will not be squash-merged at release time.